[U-Boot-Users] [PATCH 1/4] Add ALIGN() macro

Wolfgang Denk wd at denx.de
Wed May 21 00:33:15 CEST 2008


In message <4833487F.1010502 at freescale.com> you wrote:
>
> > #define ALIGN(x, a)		__ALIGN_MASK(x, (typeof(x)) (a) - 1)
> > #define __ALIGN_MASK(x, mask)	(((x) + (mask)) & ~(mask))
> 
> That's not indenting, that's alignment.  Using tabs after anything that 

OK. Then I will add this requirement to the Coding Style documentation
now.

> is not a tab causes the code to look awful if the tab stops are 
> disturbed, such as by viewing with a different tab size, or as part of a 
> patch.

What do you mean by "a different tab size"? TABs are always 8
characters, always and everywhere.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Death. Destruction. Disease. Horror. That's what war  is  all  about.
That's what makes it a thing to be avoided.
	-- Kirk, "A Taste of Armageddon", stardate 3193.0




More information about the U-Boot mailing list