[U-Boot-Users] [PATCH-v3] Big white-space cleanup.

Kim Phillips kim.phillips at freescale.com
Wed May 21 17:40:40 CEST 2008


On Wed, 21 May 2008 15:34:32 +0200
Wolfgang Denk <wd at denx.de> wrote:

> In message <48341837.7010302 at ruby.dti.ne.jp> you wrote:
> >
> > Unfortunately several wrong fixes or false positives still remains,
> > but this patch definitely reduce the number of wrong indentations.
> 
> Could you please point out the remaining problems?  If  I  understand
> what's  gone  wrong  I probably can fix my procedure and spin another
> patch?
> 

although the existing patch should definitely stay committed, here are a
couple of examples of things I'd expect it to have fixed:

board/freescale/mpc8349itx/mpc8349itx.c:120
board/freescale/mpc8349itx/mpc8349itx.c:275
board/freescale/mpc8349emds/pci.c:56

Also, although less authoritative (esp. for u-boot),
linux-2.6/scripts/checkpatch.pl output is always interesting on these
types of patches.

I'll be sure to get some by hand - I understand these expressions
sometimes get too unwieldly too fast.

Kim




More information about the U-Boot mailing list