[U-Boot-Users] [PATCH] PPC4xx: Simplified post_word_{load, store}

[Wolfgang Denk]

In message <1211394262-26658-1-git-send-email-gerickson at nuovations.com> you wrote:
> This patch simplifies post_word_{load,store} by using the preprocessor 
> to eliminate redundant, copy-and-pasted code.
...
> +#if defined(CFG_POST_WORD_ADDR)
> +# define _POST_ADDR	CFG_OCM_DATA_ADDR + CFG_POST_WORD_ADDR

Please make this

# define _POST_ADDR ((CFG_OCM_DATA_ADDR) + (CFG_POST_WORD_ADDR))

> +#elif defined(CFG_POST_ALT_WORD_ADDR)
> +# define _POST_ADDR	CFG_POST_ALT_WORD_ADDR

# define _POST_ADDR	(CFG_POST_ALT_WORD_ADDR)


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If I don't document something, it's usually either for a good reason,
or a bad reason.  In this case it's a good reason.  :-)
                 - Larry Wall in <1992Jan17.005405.16806 at netlabs.com>