[U-Boot-Users] [PATCH] socrates: add USB support

Markus Klotzbücher mk at denx.de
Thu May 22 11:59:26 CEST 2008


Sergei, Wolfgang,

Wolfgang Denk <wd at denx.de> writes:

> From: Sergei Poselenov <sposelenov at emcraft.com>
>
> Add new configuration variable CONFIG_PCI_OHCI_DEVNO.
> In case of several PCI USB controllers on a board this variable
> specifys which controller to use.
> See doc/README.generic_usb_ohci for details.
>
> Signed-off-by: Sergei Poselenov <sposelenov at emcraft.com>
> ---
> Markus, please note that we added a new configuration variable,
> CONFIG_PCI_OHCI_DEVNO in drivers/usb_ohci.c. It addresses the the
> case when there are several USB controllers installed on a board
> (like on socrates, where 4 PCI OHCI USB controllers are available),
> and we need to support a controller instance other than the first
> found.
>
> For socrates, currently it is the 2nd OHCI controller of the 2nd
> ISP1562 PCI USB chip (i.e. instance number 3 in the PCI list of OHCI
> controllers (0x1131/0x1561)).

Patch looks ok (and passed the sequoia test) so:

Acked-by: Markus Klotzbuecher <mk at denx.de>

But for the future:

- The subject is less than meaningful. 

- I would have really preferred two patches, one for the generic change
  and one for updating the board config.

Wolfgang, do you want to pick this one up directly (preferably with a
more meaningful subject) or shall I push it through the usb tree. Either
is fine for me.

Best regards

Markus Klotzbücher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de




More information about the U-Boot mailing list