[U-Boot-Users] [PATCH] avr32: Fix wrong error flags in atmel_mci driver

[Haavard Skinnemoen]

[trimming Cc list]

"Gururaja Hebbar K R" <gururajakr at sanyo.co.in> wrote:
> 
> Hi Haavard Skinnemoen,
> 
> while you are working on atmel mci mmc driver, i would like to know
> whether you can tell me anything about the bug mentioned here 
> 
> Possible Bug in at32ap mmc driver atmel_mci.c related to incorrect usage
> of variables.
> 
> 
> http://www.nabble.com/Possible-Bug-in-at32ap-mmc-driver-atmel_mci.c-td16
> 111511.html#a16111511

Hmm...I think I missed that one. But yes, I think you found a bug.

The patch below should fix it. Normally, you won't actually see any
difference because command CRC errors are quite rare, but we should at
least try to do it correctly...

Haavard

==================[cut here]=======================
From f7bbc61b3e427349f467caac93e6421402c17839 Mon Sep 17 00:00:00 2001
From: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>
Date: Thu, 22 May 2008 12:28:25 +0200
Subject: [PATCH] avr32: Fix wrong error flags in atmel_mci driver

Make sure we check for CRC errors when sending commands that use CRC
checking.

Reported-by: Gururaja Hebbar K R <gururajakr at sanyo.co.in>
Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>
---
 cpu/at32ap/atmel_mci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/at32ap/atmel_mci.c b/cpu/at32ap/atmel_mci.c
index 3ce9ea5..226b5c0 100644
--- a/cpu/at32ap/atmel_mci.c
+++ b/cpu/at32ap/atmel_mci.c
@@ -139,7 +139,7 @@ mmc_cmd(unsigned long cmd, unsigned long arg,
 
 	pr_debug("mmc: status 0x%08lx\n", status);
 
-	if (status & ERROR_FLAGS) {
+	if (status & error_flags) {
 		printf("mmc: command %lu failed (status: 0x%08lx)\n",
 		       cmd, status);
 		return -EIO;
-- 
1.5.5.1