[U-Boot-Users] [PATCH 06/18] avr32: Add support for the ATSTK1006 board

[Haavard Skinnemoen]

Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:
> > +#define CFG_DCACHE_LINESZ		32
> > +#define CFG_ICACHE_LINESZ		32
> > +
> > +#define CONFIG_NR_DRAM_BANKS		1
> > +
> > +/* External flash on STK1000 */
> > +#if 0
> is it possible to use CFG_EXTERNAL_FLASH or something?
> > +#define CFG_FLASH_CFI			1
> > +#define CFG_FLASH_CFI_DRIVER		1
> > +#endif

Actually, I've been wanting to switch to the CFI driver for the STK1000
and its derivatives for a long time. However, the (obsolete) AT49BV6416
chip needs a fixup due to wrong erase region information, and there's
currently no way to tell it apart from AT49BV642D, which doesn't need
the fixup, since the CFI driver only reads the lower 8 bits of the
device ID.

So while fixing the CFI driver isn't exactly top priority right now,
this #if 0 block is very much intended as a temporary thing.

> > +/* Other configuration settings that shouldn't have to change all that often */
> > +#define CFG_PROMPT			"Uboot> "
> In the precedent patch you put U-Boot is possible to do it here too?

Absolutely. Nice catch.

I'm going to fold the below patch into this; there were a couple of
other things that weren't in sync with patch #1 as well.

Thanks for reviewing!

Haavard

---
 include/configs/atstk1006.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/atstk1006.h b/include/configs/atstk1006.h
index c3de434..9fd49a5 100644
--- a/include/configs/atstk1006.h
+++ b/include/configs/atstk1006.h
@@ -141,9 +141,9 @@
 #define CONFIG_CMD_FAT
 #define CONFIG_CMD_JFFS2
 #define CONFIG_CMD_MMC
-#define CONFIG_CMD_REGINFO
 
 #undef CONFIG_CMD_AUTOSCRIPT
+#undef CONFIG_CMD_FPGA
 #undef CONFIG_CMD_SETGETDCR
 #undef CONFIG_CMD_XIMG
 
@@ -190,7 +190,7 @@
 #define CFG_BOOTPARAMS_LEN		(16 * 1024)
 
 /* Other configuration settings that shouldn't have to change all that often */
-#define CFG_PROMPT			"Uboot> "
+#define CFG_PROMPT			"U-Boot> "
 #define CFG_CBSIZE			256
 #define CFG_MAXARGS			16
 #define CFG_PBSIZE			(CFG_CBSIZE + sizeof(CFG_PROMPT) + 16)
-- 
1.5.5.1