[U-Boot-Users] [MIPS] Convert CPU type name into CONFIG_CPU_*
Shinya Kuribayashi
skuribay at ruby.dti.ne.jp
Sun May 25 17:15:40 CEST 2008
Wolfgang Denk wrote:
> In message <48381B6C.5000901 at ruby.dti.ne.jp> you wrote:
>> Adjust to the current Linux way.
>>
>> Signed-off-by: Shinya Kuribayashi <skuribay at ruby.dti.ne.jp>
> ...
>> -#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
>> +#define CONFIG_CPU_MIPS32_R1 1 /* MIPS32 CPU core */
>
> I have to admit that I don't like this changes.
>
> We're adding a lot of fine ganularity here
First of all, current CONFIG_MIPS32 defines are useless. We can even
remove them. What is fine granularity for, huh?
skuribay at debian:~/devel/u-boot.git$ grep -r CONFIG_MIPS32 .
./include/configs/qemu-mips.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/dbau1x00.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/gth2.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/purple.h:#define CONFIG_MIPS32 1 /* MIPS 5Kc CPU core */
./include/configs/tb0229.h:#define CONFIG_MIPS32 1 /* MIPS 4Kc CPU core */
./include/configs/pb1x00.h:#define CONFIG_MIPS32 1 /* MIPS32 CPU core */
./include/configs/incaip.h:#define CONFIG_MIPS32 1 /* MIPS 4Kc CPU core */
skuribay at debian:~/devel/u-boot.git$
[btw tb0229 is not MIPS32 at all. it's VR4131 based machine.]
> What exactly is the reason for all these changes? Which problem are
> you trying to fix?
It'll be good we could have CPU type specifier so that we can utilize as
a compiler/assembler optimization.
And why I use CONFIG_CPU_MIPS32_R1, instead of CONFIG_CPU_MIPS32, is due
to avoiding #ifdef mess. CONFIG_CPU_MIPS32 is inadequate for this use.
We need _R1 or _R2. Linux is doing well with the help of Kconfig.
Probably I should have fold this patch and `[MIPS] CPU-dependent
compiler/assembler options for optimization' patch into one.
Thought?
Shinya
More information about the U-Boot
mailing list