[U-Boot-Users] [PATCH] Move conditional compilation of MPC8XXX SPI driver to Makefile

[Ben Warren]

Wolfgang Denk wrote:
> Dear Ben,
>
> in message <1211783488-30985-1-git-send-email-biggerbadderben at gmail.com> you wrote:
>   
>> diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
>>     
> ...
>   
>> -COBJS-y += mpc8xxx_spi.o
>> +COBJS-$(CONFIG_MPC8XXX_SPI) += mpc8xxx_spi.o
>>     
>
> i. e. we move CONFIG_MPC8XXX_SPI into the Makefile...
>
>   
>> diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
>>     
> ...
>   
>> -#if defined(CONFIG_MPC8XXX_SPI) && defined(CONFIG_HARD_SPI)
>>     
>
> ...but that would leave the "#ifded CONFIG_HARD_SPI" part still in
> place. Or am I missing something?
>   
If CONFIG_MPC8XXX_SPI is defined but CONFIG_HARD_SPI is not, compilation 
will fail, since CONFIG_HARD_SPI activates the common SPI code on 
PowerPC.  I guess I figured Kconfig would eventually manage the 
dependencies of these options, but I will put the #ifdef back in if you 
want.

regards,
Ben