[U-Boot-Users] [PATCH] Fix incorrect switch for IF_TYPE in part.c

Martin Krause Martin.Krause at tqs.de
Tue May 27 12:04:14 CEST 2008


Hi Tor,

that's funny, we found this bug also - two minutes before
you send the patch :-).

u-boot-users-bounces at lists.sourceforge.net wrote on :
> Use correct field in block_dev_desc_t when writing interface type in
> dev_print. Error introduced in
> 574b319512b13e10800f0045e39b993f4ca25e42. 
> 
> Signed-off-by: Tor Krill <tor at excito.com>
> ---
>  disk/part.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/disk/part.c b/disk/part.c
> index 316e254..6a1b1f8 100644
> --- a/disk/part.c
> +++ b/disk/part.c
> @@ -109,7 +109,7 @@ void dev_print (block_dev_desc_t *dev_desc)
>  	lbaint_t lba512;
>  #endif
> 
> -	switch (dev_desc->type) {
> +	switch (dev_desc->if_type) {
>  	case IF_TYPE_SCSI:
>  		printf ("(%d:%d) Vendor: %s Prod.: %s Rev: %s\n",
>  			dev_desc->target,dev_desc->lun,

Maybe it is a good idea to change the default path of the
switch statement in Line 127 also:

-	case DEV_TYPE_UNKNOWN:
+	case IF_TYPE_UNKNOWN:

Best Regards,
Martin Krause




More information about the U-Boot mailing list