[U-Boot] [PATCH 1/1] device: clone device on register

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Sep 1 21:50:26 CEST 2008


On 18:15 Mon 01 Sep     , Haavard Skinnemoen wrote:
> Haavard Skinnemoen <haavard.skinnemoen at atmel.com> wrote:
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:
> > > to prevent that the pointer will not be use for an other register
> > > 
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>  
> > 
> > Er. What? If a device is registered multiple times, that sounds like
> > something which should be fixed, not papered over like this...
> 
> I take that back. I didn't realize how much of a f***ing trainwreck the
> device system is...apparently the callers expect device_register() to
> clone the device, but this fact was hidden well within the old list
> implementation. Your patches makes this much more apparent, which is
> obviously good.
> 
> Oh, and your patch fixes the breakage I was seeing on avr32. Thanks.

I've plan to cleanup this part during next release.

and redesign console management to simplify it and reduce its code.

I'm currently designing a generic bus/device/driver mecanism that will
simplify the implementation without increase the size.

I'll send a announce about it

Best Regards,
J.


More information about the U-Boot mailing list