[U-Boot] [PATCH 2/5] atmel_lcdfb: Straighten out funky vl_sync logic

[Haavard Skinnemoen]

Detlev Zundel <dzu at denx.de> wrote:
> What about
> 
> 	value |= panel_info.vl_sync & (ATMEL_LCDC_INVLINE_INVERTED | ATMEL_LCDC_INVFRAME_INVERTED);
> 
> [break lines where convenient] Apart from this being the formal
> equivalent to the original code, this would make it more clear what can
> go in, no?

Well, there's also INVVD, INVCLK and INVDVAL which the original code
doesn't care about at all. I'm not sure if all of them are suitable for
the vl_sync field, but perhaps the field should be renamed.

In Linux, there's just a default_lcdcon2 field which the board code can
use to set any flags it wants. I'm not sure if the driver should really
bother too much about those flags anyway -- almost all of them depend
on the type of display, how it's hooked up, etc.

Haavard