[U-Boot] unassigned-patches/25: [PATCH] USB EHCI: reset root hub

Markus Klotzbücher mk at denx.de
Thu Sep 4 10:44:26 CEST 2008


Dear Yuri,

On Fri, Aug 15, 2008 at 03:45:02PM +0200, u-boot at bugs.denx.de wrote:

>  Some of multi-function USB controllers (e.g. ISP1562) allow root hub
> resetting only via EHCI registers. So, this patch adds the corresponding
> kind of reset to OHCI's hc_reset() if the newly introduced CONFIG_PCI_EHCI_DEVNO
> option is set (e.g. for Socrates board).
> 
> Signed-off-by: Yuri Tikhonov <yur at emcraft.com>
> 
> ---
> Added to GNATS database as unassigned-patches/25
> >Responsible:    patch-coord
> >Message-Id:     <1218807733-26929-3-git-send-email-dzu at denx.de>
> >In-Reply-To:    <1218807733-26929-2-git-send-email-dzu at denx.de>
> >References:     <1218807733-26929-1-git-send-email-dzu at denx.de> <1218807733-26929-2-git-send-email-dzu at denx.de>
> >Patch-Date:     Fri Aug 15 15:42:10 +0200 2008
> ---
>  drivers/usb/usb_ohci.c     |   31 +++++++++++++++++++++++++++++++
>  drivers/usb/usb_ohci.h     |    3 +++
>  include/configs/socrates.h |    1 +
>  3 files changed, 35 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c
> index fd60edb..0f5bd06 100644
> --- a/drivers/usb/usb_ohci.c
> +++ b/drivers/usb/usb_ohci.c
> @@ -1571,11 +1571,42 @@ int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
>  
>  static int hc_reset (ohci_t *ohci)
>  {
> +#ifdef CONFIG_PCI_EHCI_DEVNO
> +	pci_dev_t pdev;
> +	struct pci_device_id ehci_pci_ids[] = {
> +		{0x1131, 0x1562},	/* Philips 1562 PCI EHCI module ids */
> +		{0, 0}
> +	};

Please move this out of the function, preferrably next to the OHCI
device ids.

Thanks!

Best regards

Markus

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de")


More information about the U-Boot mailing list