[U-Boot] [PATCH] devices: Use list_add_tail() instead of list_add() to register a device

Stefan Roese sr at denx.de
Fri Sep 5 10:47:46 CEST 2008


This patch fixes a problem spotted on Glacier/Canyonlands (and most
likely lots of other board ports), that no serial output was seen
after console initialization in console_init_r(). This is because the
last added console device was used instead of the first added.

This patch fixes this problem by using list_add_tail() instead of
list_add() to register a device. This way the first added console
is used again.

Signed-off-by: Stefan Roese <sr at denx.de>
---
 common/devices.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/devices.c b/common/devices.c
index 8beebe2..7d0ac2e 100644
--- a/common/devices.c
+++ b/common/devices.c
@@ -155,7 +155,7 @@ int device_register (device_t * dev)
 	_dev = device_clone(dev);
 	if(!_dev)
 		return -1;
-	list_add(&(_dev->list), &(devs.list));
+	list_add_tail(&(_dev->list), &(devs.list));
 	return 0;
 }
 
-- 
1.5.6.5



More information about the U-Boot mailing list