[U-Boot] [U-Boot-Users] [PATCH] Optimize ext2fs read functions

[Wolfgang Denk]

Dear Ryan,

In message <00b001c901aa$56c5c700$30065e0a at SHZ.ST.COM> you wrote:
>
> I'm sorry that I can't send patch mail by git-send-mail because I'm in ST internal network. 
> I just post the whole output by git-format-patch tool. 

That's OK.

> If it's buggy, please let me know. 

Not really buggy, but:

> 
> >From 0a08bfe1f0fc864a9920501a825e6698d082f231 Mon Sep 17 00:00:00 2001
> From: Ryan Chen <ryan.chen at st.com>
> Date: Tue, 19 Aug 2008 07:11:23 -0400
> Subject: [PATCH] Optimize ext2fs read functions
> 
> ---

Your Signed-off-by: line is missing here.

And there were a few white space errors in your code:

.dotest/patch:94: trailing whitespace.
                while(((inode->b.blocks.dir_blocks[fileblock + 1] - 
.dotest/patch:174: trailing whitespace.
                blknr = blknr << log2blocksize;
.dotest/patch:175: trailing whitespace.

.dotest/patch:181: trailing whitespace.

.dotest/patch:186: trailing whitespace.

warning: squelched 2 whitespace errors
warning: 7 lines applied after fixing whitespace errors.



I can confirm that the code indeed improves read performance;  in  my
tests (reading a file of 1580 KiB from a PCMCIA attached harddisk ona
MPC855P  at  66 MHz) I measured an improvement of about 2.8, i. . the
read time for this fil went down from 7.2 to 2.6 seconds.


Please clean up and resubmit.   Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quotation, n. The act of repeating erroneously the words of  another.
The  words  erroneously  repeated.
                            - Ambrose Bierce _The Devil's Dictionary_