[U-Boot] [REGRESSION] commit b502611b51... "Change env_get_char from a..." breaks imx31_phycore

[Magnus Lilja]

2008/9/6 Guennadi Liakhovetski <lg at denx.de>:
> On Sat, 6 Sep 2008, Wolfgang Denk wrote:
>
>> Dear Guennadi Liakhovetski,
>>
>> In message <Pine.LNX.4.64.0809061015510.3731 at axis700.grange> you wrote:
>> >
>> > Hence the question: shell we set GD_FLG_RELOC centrally really for all
>> > boards or are there boards out there that really must not have this flag
>> > set?
>>
>> No matter how U-Boot starts up (whether it starts itself, for example
>> by running in ROM/NOR flash rightout of the processor's reset, or if
>> it gets loaded into RAM by some other mechanism), at a certain point
>> in the initalization sequence, U-Boot will run out of RAM.
>>
>> For regular implementations of U-Boot  this  is  implemented  in  the
>> board_init_r()  function,  and  it  is one of the first actions to be
>> done in board_init_r() to add GD_FLG_RELOC to the global flags.
>>
>> Any other implementation (including  that  for  ARM)  must  also  set
>> GD_FLG_RELOC  as soon as it reaches the code whis is run from RAM for
>> all  configurations;  my   understanding   is   that   this   is   in
>> start_armboot(), right after the global data has been initialized.
>
> Was this patch correct then?
>
> http://lists.denx.de/pipermail/u-boot/2008-July/037375.html

That's what I've been doing locally in order to get
CONFIG_CMDLINE_EDITING to work so it seems correct.

Regards/Magnus