[U-Boot] [PATCH] Suppressing Diagnostic Output for 'fw_setenv'

Guennadi Liakhovetski lg at denx.de
Sun Sep 7 21:41:56 CEST 2008


On Sun, 7 Sep 2008, Wolfgang Denk wrote:

> Dear Grant Erickson,
> 
> In message <1220079161-18217-1-git-send-email-gerickson at nuovations.com> you wrote:
> > Added support for a ``-v'' option for fw_setenv to explicitly enable
> > what was formerly default verbose diagnostic output when updating the
> > environment.
> > 
> > Signed-off-by: Grant Erickson <gerickson at nuovations.com>
> > ---
> >  tools/env/fw_env.c      |   43 +++++++++++++++++++++++++++++--------------
> >  tools/env/fw_env_main.c |    4 +++-
> >  2 files changed, 32 insertions(+), 15 deletions(-)
> 
> I will not apply this patch for now, as I expect that  Guennadi  will
> address  this  issue  in  his  rewrite  of the fw_setenv command when
> adding NAND support.
> 
> Please check again and  resubmit  (if  still  needed)  later  (affter
> Guennadi's patch went in).

In my last patch version (v2, submitted last Thursday, 4 Sep), I put all 
debugging output in "#ifdef DEBUG" blocks. So, if this patch is accepted 
in its current form, you will have to look at those ifdef's and see which 
of them you want to make dynamically selectable per '-v' switch.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list