[U-Boot] [PATCH] [UPDATE #2] Merged serial_pl010.c and serial_pl011.c.

Wolfgang Denk wd at denx.de
Mon Sep 8 12:49:51 CEST 2008


Dear Andreas Engel,

In message <48C4F061.1090609 at ericsson.com> you wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:17 Mon 08 Sep     , Andreas Engel wrote:
> >> [...]
> >>
> >> -#ifdef CFG_PL010_SERIAL
> >> +#if defined(CFG_PL010_SERIAL) || defined(CFG_PL011_SERIAL)
> > Please move this to the Makefile
> 
> Shouldn't this better be a separate patch?

Yes, indeed.

Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You have the capacity to learn from  mistakes.  You'll  learn  a  lot
today.


More information about the U-Boot mailing list