[U-Boot] [PATCH] [ARM] Moved conditional compile into Makefile

Wolfgang Denk wd at denx.de
Mon Sep 8 16:06:58 CEST 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20080908133035.GB3956 at game.jcrosoft.org> you wrote:
>
> what append if CONFIG_PL010_SERIAL and CONFIG_PL011_SERIAL is active at the
> same time?

Then something is missing.

> serial_pl01x.c will be compile twice
> 
> so please move to 
> +COBJS-$(CONFIG_PL010_SERIAL)$(CONFIG_PL011_SERIAL) += serial_pl01x.o

This alone is not sufficient, since then you need to add a  rule  for
the resulting COBJS-yy.

But as I learned all of this is completely unnecessary.

As Detlev Zundel pointed out, just doing "COBJS-y = $(sort COBJS-y)"
would fix any such problems in a clean and readable way.

I recommend to add such a statement instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do you know about being with somebody? Wanting to be? If  I  had  the
whole  universe,  I'd  give it to you, Janice. When I see you, I feel
like I'm hungry all over. Do you know how that feels?
	-- Charlie Evans, "Charlie X", stardate 1535.8


More information about the U-Boot mailing list