[U-Boot] [PATCH][for 1.3.5] Fix handling of mem reserves for ramdisk

Kumar Gala galak at kernel.crashing.org
Mon Sep 8 17:57:54 CEST 2008


On Sep 8, 2008, at 9:10 AM, Wolfgang Denk wrote:

> Dear Kumar Gala,
>
> In message <6E892604-9B2A-4338-8DF7- 
> C58688FC5A94 at kernel.crashing.org> you wrote:
>>
>> The reason we had the code before was to try and make sure the size  
>> of
>> the fdt was as close to its final size as possible before we dealt
>> with the ramdisk relocation (boot_ramdisk_high()) that included the
>> properties and the memreserve in the fdt.  Step's a)-c) are there to
>> make sure the size is correct.
>
> Well, but the size needed for this should be a constant, so it should
> be sufficioent to determine  it  once  and  then  use  a  hard  coded
> constant; eventually add some padding.
>
> Doing this in runtime is a waste of resources (flash memory, RAM, and
> time - not to mention human time for maintaining the code).

I'm ok with determining the size bump and doing it that way.

- k


More information about the U-Boot mailing list