[U-Boot] [PATCH] ppc4xx: Fix compilation warning for canyonlands &glacier

Victor Gallardo vgallardo at amcc.com
Mon Sep 8 19:22:47 CEST 2008


Oops, Sorry Stefan my fault for introducing this. 

Thanks for fixing this.

Regards

Victor Gallardo

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
On Behalf Of Stefan Roese
Sent: Friday, September 05, 2008 5:13 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Fix compilation warning for
canyonlands &glacier

Signed-off-by: Stefan Roese <sr at denx.de>
---
 cpu/ppc4xx/miiphy.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/cpu/ppc4xx/miiphy.c b/cpu/ppc4xx/miiphy.c index
d303598..84b1bbe 100644
--- a/cpu/ppc4xx/miiphy.c
+++ b/cpu/ppc4xx/miiphy.c
@@ -236,28 +236,24 @@ unsigned int miiphy_getemac_offset(u8 addr)
#endif
 
 #if defined(CONFIG_460EX) || defined(CONFIG_460GT)
-	u32 mode_reg;
 	u32 eoffset = 0;
 
 	switch (addr) {
 #if defined(CONFIG_HAS_ETH1) && defined(CONFIG_GPCS_PHY1_ADDR)
 	case CONFIG_GPCS_PHY1_ADDR:
-		mode_reg = in_be32((void *)EMAC_M1 + 0x100);
-		if (addr == EMAC_M1_IPPA_GET(mode_reg))
+		if (addr == EMAC_M1_IPPA_GET(in_be32((void *)EMAC_M1 +
0x100)))
 			eoffset = 0x100;
 		break;
 #endif
 #if defined(CONFIG_HAS_ETH2) && defined(CONFIG_GPCS_PHY2_ADDR)
 	case CONFIG_GPCS_PHY2_ADDR:
-		mode_reg = in_be32((void *)EMAC_M1 + 0x300);
-		if (addr == EMAC_M1_IPPA_GET(mode_reg))
+		if (addr == EMAC_M1_IPPA_GET(in_be32((void *)EMAC_M1 +
0x300)))
 			eoffset = 0x300;
 		break;
 #endif
 #if defined(CONFIG_HAS_ETH3) && defined(CONFIG_GPCS_PHY3_ADDR)
 	case CONFIG_GPCS_PHY3_ADDR:
-		mode_reg = in_be32((void *)EMAC_M1 + 0x400);
-		if (addr == EMAC_M1_IPPA_GET(mode_reg))
+		if (addr == EMAC_M1_IPPA_GET(in_be32((void *)EMAC_M1 +
0x400)))
 			eoffset = 0x400;
 		break;
 #endif
--
1.5.6.5

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


More information about the U-Boot mailing list