[U-Boot] [PATCH] Remove CONFIG_SHOW_ACTIVITY from stx boards which don't support it
Wolfgang Denk
wd at denx.de
Tue Sep 9 09:38:10 CEST 2008
Dear Andy Fleming,
In message <1220925000-3903-1-git-send-email-afleming at freescale.com> you wrote:
> commit 9cff4448a9cb882defe6c8bde73b77fc0c636799 removed the mpc85xx version
> of timer_interrupt, which was overriding the lib_ppc version. The lib_ppc
> version tries to invoke board_show_activity() if CONFIG_SHOW_ACTIVITY is
> defined. stxgp3 and stxssa defined it, despite not defining
> board_show_activity(). I'll leave it to the stx* maintainer to
> implement that function if desired. :)
Your patch is incorrect as it not only disables board_show_activity()
which indeed is not implemented on these boards, but it also disables
show_activity() which *is* implemented and shall not be touched.
NAK!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Though a program be but three lines long,
someday it will have to be maintained."
- The Tao of Programming
More information about the U-Boot
mailing list