[U-Boot] [PATCH 1/2] Update i386 code (sc520_cdp)

[Graeme Russ]

On Tue, Sep 9, 2008 at 7:49 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Graeme Russ,
>
> In message <1220735322.6322.8.camel at devel> you wrote:
>> Attempt to bring i386 / sc520 inline with master
>
> To make some progress, I manually fixed the wrapped lines (you owe me
> a beer for that) and applied most of your patch.

Agreed

>
> I omitted this part though:
>
>> diff --git a/include/image.h b/include/image.h
>> index 9be806e..e095a32 100644
>> --- a/include/image.h
>> +++ b/include/image.h
>> @@ -40,7 +40,7 @@
>>  #include <lmb.h>
>>  #include <linux/string.h>
>>  #include <asm/u-boot.h>
>> -
>> +#include <asm/string.h>
>>  #else
>
> Including <asm/string.h> seems bogus to me as this is already done in
> <linux/string.h> which is  included  just  two  lines  above.  Please
> check.

I've rechecked, but removing this include results in an implicit
declaration of function 'strncpy' on line 401 of /include/image.h

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> panic: kernel trap (ignored)
>