[U-Boot] [PATCH] ppc4xx: ppc440-generic-ALL: Fix out of tree build

[Wolfgang Denk]

Dear Ricardo Ribalda Delgado,

In message <1220963467-17361-1-git-send-email-ricardo.ribalda at uam.es> you wrote:
> This patch solves the problems compiling ml507, v5fx30teval and
> ppc440-generic out of tree.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at uam.es>
> ---
>  Makefile                             |   49 +++++++++++++++++++++++-----------
>  board/xilinx/ppc440-generic/Makefile |    4 +-
>  2 files changed, 35 insertions(+), 18 deletions(-)

NAK. This patch is definitely wrong.


> diff --git a/Makefile b/Makefile
> index a342a88..c5ec313 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1359,17 +1359,21 @@ ml300_config:	unconfig
>  	@$(MKCONFIG) $(@:_config=) ppc ppc4xx ml300 xilinx
>  
>  ml507_flash_config: unconfig
> +	@mkdir -p $(obj)include $(obj)board/xilinx/ppc440-generic
>  	@mkdir -p $(obj)include $(obj)board/xilinx/ml507
> -	@echo "LDSCRIPT  := $(obj)board/xilinx/ppc440-generic/u-boot-rom.lds" \
> -		> $(obj)board/xilinx/ml507/config.mk
> -	@echo "TEXT_BASE := 0xFE360000" >> $(obj)board/xilinx/ml507/config.mk
> +	@echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc440-generic/u-boot-rom.lds"\
> +		> $(SRCTREE)/board/xilinx/ml507/config.mk
> +	@echo "TEXT_BASE := 0xFE360000" \
> +		>> $(SRCTREE)/board/xilinx/ml507/config.mk

SRCTREE is the source directory; when using out-of-tree builds, no file
must ever written to or created in that directory tree.

You are allowed to create only files in the $(obj) tree.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our way is peace.
	-- Septimus, the Son Worshiper, "Bread and Circuses",
	   stardate 4040.7.