[U-Boot] [PATCH 2/3] fix checkpatch errors

Hugo Villeneuve hugo.villeneuve at lyrtech.com
Tue Sep 9 17:02:55 CEST 2008


git diff ${GITDIFF_OPTS} ${commit} >> ${patch}.patchu-boot-bounces at lists.denx.de wrote:
> Dear Georg Schardt,
> 
> In message <48C3B358.6010500 at team-ctech.de> you wrote:
>> 
>> - create my own testing branch: "git branch testing"
>> - switch to this branch: "git checkout testing"
>> - copy/modify files
>> - add the new files with "git add board/xilinx/fx12mm/"
>> - commit the changes with "git commit -a"
>> - create a patch with "git format-patch origin"
>> - check this patch with checkpatch.pl
>> - fix the errors, commit again, create patch again get 2 patchfiles

I´m not an expert with GIT, but I would suggest the following change to avoid unnecessary commits:

1.  Create my own testing branch: "git branch testing"
2.  Switch to this branch: "git checkout testing"
3.    Copy/modify files
4.    Create temporary patch from local changes: "git diff > temporary.patch"
5.    Check this patch with checkpatch.pl
6.  If errors found: go back to step 3, else go to step 7
7.  Add the new/modified files with "git add board/xilinx/fx12mm/"
8.  Commit the changes with "git commit -a"
9.  Create a patch with "git format-patch origin"
10. Check this patch with checkpatch.pl

Hugo V.

Hugo Villeneuve
Hardware developer | Concepteur matériel
Lyrtech
Phone/Tél. : (1) (418) 877-4644 #2395
Toll-free/Sans frais - Canada & USA : (1) (888) 922-4644 #2395
Fax/Téléc. : (1) (418) 877-7710
www.lyrtech.com
Infinite possibilities...TM


More information about the U-Boot mailing list