[U-Boot] [PATCH 1/2] bootm: active fdt support only on ppc, m68k and sparc as done in image.c

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1220991504-20366-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  common/cmd_bootm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 861712b..2b4df80 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -251,6 +251,7 @@ static int bootm_start(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>  		}
>  
>  #if defined(CONFIG_OF_LIBFDT)
> +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
>  		/* find flattened device tree */
>  		ret = boot_get_fdt (flag, argc, argv, &images,
>  				    &images.ft_addr, &images.ft_len);
> @@ -261,6 +262,7 @@ static int bootm_start(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>  
>  		set_working_fdt_addr(images.ft_addr);
>  #endif
> +#endif

I think this is not correct. There  are  even  PPC  board  where  FDT
support  is  not  enabled  because  CONFIG_OF_LIBFDT is not set. Your
patch would change that - what's wrong with enabling CONFIG_OF_LIBFDT
for the boards where you want to use it?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
G's Third Law:             In spite of all evidence  to  the  contra-
ry,  the  entire  universe  is composed of only two basic substances:
magic and bullshit.
H's Dictum:                There is no magic ...