[U-Boot] [PATCH 2/2] IOMUX: Add console multiplexing support.

[Wolfgang Denk]

Dear Gary Jennejohn,

In message <20080914191918.7de10c5c at peedub.jennejohn.org> you wrote:
> 
> > 2) You only add new points where the GD_FLG_DEVINIT bit gets set in
> > gd->flags. That means there are two possibilities when your newly
> > added code is run: either, this bit is already set by other parts of
> > the codem than the operation was redundant and couldbe omitted; or,
> > the flasg was not set yet, then you set it now, which means you set it
> > EARLIE than it would have been set before.
> > 
> > But your comment suggests that that would be done LATER now.
> > 
> > 
> > So what exactly is the purpose of this patch?
> 
> This bit is normally ser in console_init_r, which is called very early.
> 
> You have to look at this patch in conjunction with the first patch and
> not as a separate entity, which it most definitely is not.

Sorry, but this doesn't work. If you split patches, you have to do it
in an orthogoanl way, such that each patch on it's own  makes  sense.
This  patch  doesn't  make  any  sense  as is. Maybe theree are parts
missing that may be buried somewhere in some other patch, but  please
do not expect that we will try to find them.

Please re-split patches such that they are independent of each  other
(except  maybe  that one has to be applied first), and make sure that
each patch is complete in itself.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Oblivion together does not frighten me, beloved.
	-- Thalassa (in Anne Mulhall's body), "Return to Tomorrow",
	   stardate 4770.3.