[U-Boot] [PATCH 1/1] i.MX31: switch to CFG_HZ=1000

Wolfgang Denk wd at denx.de
Sun Sep 21 22:54:39 CEST 2008


Dear Jean-Christophe,

in message <Pine.LNX.4.64.0809201313550.5424 at axis700.grange>
Guennadi Liakhovetski wrote:
> 
> I still don't understand the purpose of this post. The patch has been 
> posted by the author to the list, you are the subsystem custodian. I 
> think, you have mainly three possibilities now:
> 
> 1. you are happy with the patch, you add your Sob, pull it into your tree 
> and ask Wolfgang to pull from it.

Actually I think that no Sob is required if a patch gets applied
without any changes.

> 2. you have minor corrections to the patch. You may correct them yourself, 
> add your Sob, re-post to the list and to the original author _specifying_ 
> in the comments section, what you have changed and asking the original 
> author if he agrees with the changes, if they are non-trivial.
> 
> 3. comment back on the patch and ask the author to fix the issues and 
> re-submit.

Agreed.

> What you have done is you modified the patch, sent it back to the list and 
> the author without your Sob and without explaining what and why you 
> modified.

This is indeed not the way it should be done.

Jean-Christophe, please fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When the bosses talk about improving  productivity,  they  are  never
talking about themselves.


More information about the U-Boot mailing list