[U-Boot] [PATCH] pci: Divided pci code of the powerpc

Stefan Roese sr at denx.de
Tue Sep 23 10:04:39 CEST 2008


On Tuesday 23 September 2008, Andy Fleming wrote:
> >>> I did a simple check.
> >>>
> >>> Only powerpc and i386 and sh seem to use PCI.
> >>> If powerpc does not have a problem, would you commit it?
> >>
> >> Do I have your "go" (or at least no veto) to apply this patch?
>
> If some of that code is powerpc-only, maybe we should move the code
> out of pci.c, too?  pci_hose_phys_to_bus() appears to be...
> board/eltec/bab7xx/pci.c only, actually.

That doesn't seem to be correct. In include/pci.h:

#define pci_phys_to_bus(dev, addr, flags) \
	pci_hose_phys_to_bus(pci_bus_to_hose(PCI_BUS(dev)), (addr), (flags))

and later:

#define pci_phys_to_mem(dev, addr)	pci_phys_to_bus((dev), (addr), PCI_REGION_MEM)
#define pci_phys_to_io(dev, addr)	pci_phys_to_bus((dev), (addr), PCI_REGION_IO)

So calling pci_phys_to_mem() or pci_phys_to_io() leads to a
pci_hose_phys_to_bus() call in the end.


Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list