[U-Boot] [PATCH] mgcoge, mgsuvd: add I2C deblocking mechanism.

Wolfgang Denk wd at denx.de
Mon Sep 29 10:57:15 CEST 2008


Dear Heiko Schocher,

In message <48E089F8.1070809 at denx.de> you wrote:
> As Documented in README, adding a boardspecific Deblocking

Which part of the README are you referring to?

> mechansim via CFG_I2C_INIT_BOARD for the mgcoge and mgsuvd
> board.

Are you talking about doc/I2C_Edge_Conditions?

> This code was originally written by keymile in association
> with Anatech and Atmel in 1998. The Code toggels the SCL
> until the SCA line goes to High (max. 16 times).
> And after this, a start Condition is send.


> Signed-off-by: Heiko Schocher <hs at denx.de>
> ---
>  board/keymile/common/common.c |  211 +++++++++++++++++++++++++++++++++++++++++
>  board/keymile/mgcoge/Makefile |    2 +-
>  drivers/i2c/soft_i2c.c        |   11 ++
>  include/configs/mgcoge.h      |    1 +
>  include/configs/mgsuvd.h      |    1 +
>  5 files changed, 225 insertions(+), 1 deletions(-)
>  create mode 100644 board/keymile/common/common.c

Hm... quoting doc/I2C_Edge_Conditions:

... Note that this is NOT necessary when using the bit-banging I2C
driver (common/soft_i2c.c) as this already includes the I2C bus reset
sequence.

Can you please explain what your patch is doing differently, and why
it is needed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A weak mind is like a microscope, which magnifies trifling things,
but cannot receive great ones.      -- Philip Earl of Chesterfield


More information about the U-Boot mailing list