[U-Boot] [PATCH] [sensor]: Make the LM75 MULTI_BUS compatible.

Wolfgang Denk wd at denx.de
Mon Sep 29 11:15:17 CEST 2008


Dear Heiko Schocher,

In message <48E089B7.8020201 at denx.de> you wrote:
> also fix CodingStyle issues for the LM75
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>
> ---
>  drivers/hwmon/lm75.c |  228 +++++++++++++++++++++++---------------------------
>  1 files changed, 105 insertions(+), 123 deletions(-)
> 
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 67a18f6..b95601d 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -50,159 +50,141 @@
> 
>  int dtt_read(int sensor, int reg)
>  {
> -    int dlen;
> -    uchar data[2];
> +	int dlen;
> +	uchar data[2];
> 

Please split your additions and any code clean up into separate
patches. As is, it's impossible to see what you actually changed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it went on at this rate, in several billion  years  he'd  be  rich
beyond his wildest dreams!            - Terry Pratchett, _Soul Music_


More information about the U-Boot mailing list