[U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Apr 1 10:01:51 CEST 2009


On 09:57 Wed 01 Apr     , Remy Bohmer wrote:
> Hello Jean-Christophe,
> 
> >> And that is exactly the issue here. The discussion is about moving
> >> 'platform USB init code' to generic driver code.
> >> I would have no problems with moving real USB drivers to the generic
> >> driver section, if they are cleaned from board specific code, of
> >> course.
> > in our case it's not a cpu specify init but an IP init which is share to
> > multiple soc for multiple arch
> 
> IMHO, that still does not justify it to make it part of the generic drivers.
> And I already mentioned yesterday, that I agree that it does not
> really belong in the cpu section as well.
> We should not pollute one area by cleaning another area.
> 
> So, we seem to be lacking a SoC/board specific section, like the linux
> kernel handles it.
> Maybe we have to work on that?
actualy it's clearly not possible and I'll not ACK any patch that dupplicate
code in the boards specialy after clean up the duplicate hardware init.

Actually the best place is the drivers/usb/

Best Regards,
J.


More information about the U-Boot mailing list