[U-Boot] [PATCH v2 1/3] 86xx: Cleanup MP support

Kim Phillips kim.phillips at freescale.com
Wed Apr 1 22:11:47 CEST 2009


On Wed,  1 Apr 2009 11:06:27 -0500
Kumar Gala <galak at kernel.crashing.org> wrote:

> -#if (CONFIG_NUM_CPUS > 1)
> -void cpu_mp_lmb_reserve(struct lmb *lmb)
> +int cpu_reset(int nr)
> +{
> +	volatile immap_t *immr = (immap_t *)CONFIG_SYS_IMMR;
> +	volatile ccsr_pic_t *pic = &immr->im_pic;

blank line here

> +	out_be32(&pic->pir, 1 << nr);
> +	(void)in_be32(&pic->pir);
> +	out_be32(&pic->pir, 0x0);

can be two setbits32

> +u32 determine_mp_bootpg(void)
> +{
>  	/* if we have 4G or more of memory, put the boot page at 4Gb-1M */
>  	if ((u64)gd->ram_size > 0xfffff000)
> -		bootpg = 0xfff00000;
> -	else
> -		bootpg = gd->ram_size - (1024 * 1024);
> +		return (0xfff00000);
> +
> +	return (gd->ram_size - (1024 * 1024));

? this line not reached

Kim


More information about the U-Boot mailing list