[U-Boot] [PATCH] Noisily disable the legacy NAND subsystem.

Scott Wood scottwood at freescale.com
Wed Apr 1 23:32:49 CEST 2009


Becky Bruce wrote:
> 
> On Apr 1, 2009, at 4:15 PM, Scott Wood wrote:
> 
>> Legacy NAND is marked for feature removal after April 2009 (i.e. this
>> upcoming release).  There are still several boards that reference it
>> (though many do so only for disk-on-chip support which has been silently
>> disabled for a while now).  These boards will now fail to build with
> 
> Drum roll....?  You're missing the rest of your sentence, or you have 
> too much sentence, or something.

D'oh.  The next line started with "#error", so git treated it as a comment.

Commit amended to say "These boards will now fail to build with #error, 
though the code is still there if the user removes #error."

>> +#error This code is broken and will be removed outright in the next 
>> release.
>> +#error If you need diskonchip support, please update
>> +#error drivers/mtd/nand/diskonchip.c to work with u-boot.
> 
> "to work with u-boot"?  As opposed to what, exactly?

Linux, where the code was taken from as part of the NAND subsystem 
importation.

> How about "please update blah to be functional"

"be functional" == "work".  I was just clarifying the nature of the 
fixing that needed to be done.

-Scott


More information about the U-Boot mailing list