[U-Boot] [PATCH] Network AT91 AVR32: generic way of addressing USRIO register layout

Ben Warren biggerbadderben at gmail.com
Fri Apr 3 00:02:31 CEST 2009


Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:41 Mon 23 Mar     , Haavard Skinnemoen wrote:
>   
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>     
>>> On 09:58 Mon 23 Mar     , Nicolas Ferre wrote:
>>>       
>>>> The MACB IP used by AVR32 & AT91 have two different layout for USRIO
>>>> register. We have to differentiate this in the driver code.
>>>> No more cpu specific #ifdefs in driver: we manage a
>>>> configuration variable.
>>>>
>>>> Signed-off-by: Nicolas Ferre <nicolas.ferre at atmel.com>  
>>>>         
>>> Ack-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
>>>
>>> Haavard is ok for you too?
>>>       
>> Sure.
>>
>> Acked-by: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>
>>     
> Ben is ok for you?
>   
It's definitely an improvement, although I'm not fond of placing the 
conditional macro in the header file.  Overall OK, though.  I'll pick it up.

regards,
Ben


More information about the U-Boot mailing list