[U-Boot] [PATCH 3/8] ZOOM2 Add support for debug board detection.

[Tom]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 22:02 Wed 01 Apr     , Tom Rix wrote:
>   
>> https://omapzoom.org/gf/project/omapzoom/wiki/?pagename=GettingStartedWithZoomII_AKA_OMAP34XII_MDP
>>
>> The zoom2 has an auxillary board that contains the serial, net, jtag and
>> battery simulator.  This change supports a runtime check if the debug board is
>> connected.
>>
>> Signed-off-by: Tom Rix <Tom.Rix at windriver.com>
>> ---
>>  board/omap3/zoom2/Makefile      |    3 +-
>>  board/omap3/zoom2/debug_board.c |   57 +++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 59 insertions(+), 1 deletions(-)
>>  create mode 100644 board/omap3/zoom2/debug_board.c
>>
>> diff --git a/board/omap3/zoom2/Makefile b/board/omap3/zoom2/Makefile
>> index 088b8cb..b8fa5a7 100644
>> --- a/board/omap3/zoom2/Makefile
>> +++ b/board/omap3/zoom2/Makefile
>> @@ -25,7 +25,8 @@ include $(TOPDIR)/config.mk
>>  
>>  LIB	= $(obj)lib$(BOARD).a
>>  
>> -COBJS	:= zoom2.o
>> +COBJS	:= zoom2.o \
>> +	debug_board.o
>>     
> you do not plan to activate it via a CONFIG only?
>   
Because the debug board can easily be removed from the zoom2,
it is necessary to have a single code base and to the checking
for the debug board at runtime. The next patch for serial output depends.

The use case is to use the debug board to load the kernel, and provide 
serial output
but to remove the debug board when using the board as normal user.


>>  
>>  SRCS	:= $(COBJS:.o=.c)
>>  OBJS	:= $(addprefix $(obj),$(COBJS))
>> diff --git a/board/omap3/zoom2/debug_board.c b/board/omap3/zoom2/debug_board.c
>> new file mode 100644
>> index 0000000..782dcb2
>> --- /dev/null
>> +++ b/board/omap3/zoom2/debug_board.c
>> @@ -0,0 +1,57 @@
>> +/*
>> + * (C) Copyright 2009
>> + * Wind River, <www.windriver.com>
>> + * Tom Rix <Tom.Rix at windriver.com>
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + *
>> + */
>> +#include <common.h>
>> +#include <asm/arch/cpu.h>
>> +#include <asm/io.h>
>> +#include <asm/arch/mux.h>
>> +
>> +#define DEBUG_BOARD_CONNECTED     1
>> +#define DEBUG_BOARD_NOT_CONNECTED 0
>> +
>> +static int debug_board_connected = DEBUG_BOARD_CONNECTED;
>>     
> why not set it as -1; and then avoid the first_time int?
>
>   
We really only want to do the gpio read once.
I looked at this. You could do this but would have to add more code.
Its a trade off of some data space for more code space.
If you really want this, I will go ahead with the changes.
Tom

> Best Regards,
> J.
>