[U-Boot] bss section initialization on s3c44b0

Wolfgang Denk wd at denx.de
Sat Apr 4 23:22:09 CEST 2009


Dear Ming-Dien Chang,

In message <714db0904012028l19743377tec224a9954017948 at mail.gmail.com> you wrote:
>
> Sorry for unfamiliar with git diff.
> The following snippet is the diff of u-boot 1.3.1 and my working.
> 
> 
> Index: Z:/u-boot/u-boot/cpu/s3c44b0/start.S
> ===================================================================
> --- Z:/u-boot/u-boot/cpu/s3c44b0/start.S    (revision 8)
> +++ Z:/u-boot/u-boot/cpu/s3c44b0/start.S    (revision 9)
> @@ -154,6 +154,26 @@
>      ble    vector_copy_loop
>  #endif    /* CONFIG_SKIP_RELOCATE_UBOOT */
> 
> +    /*
> +     * Initialize .bss section.
> +     */
> +    mov     r2, #0
> +    mov     r3, #0
> +    mov     r4, #0
> +    mov     r5, #0
> +    mov     r6, #0
> +    mov     r7, #0
> +    mov     r8, #0
> +    mov     r9, #0
> +    mov     r10, #0
> +    ldr     r0, _bss_start
> +    ldr     r1, _bss_end
> +zerolize:
> +    stmia   r0!, {r2-r10}
> +    cmp     r0, r1
> +    blt     zerolize
> +
> +
>      /* Set up the stack                            */
>  stack_setup:
>      ldr    r0, _TEXT_BASE        /* upper 128 KiB: relocated uboot   */

This looks good to me. Can you please resubmit this with a proper
commit message and your signed-off-by: line added? Please see
http://www.denx.de/wiki/U-Boot/Patches for details.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"And it should be the law: If you use  the  word  `paradigm'  without
knowing  what  the  dictionary  says  it  means,  you  go to jail. No
exceptions."                     - David Jones @ Megatest Corporation


More information about the U-Boot mailing list