[U-Boot] [PATCH] debug_print macros support

[Prafulla Wadaskar]

Dear Wolfgang Denk

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de] 
> Sent: Friday, April 03, 2009 11:23 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH] debug_print macros support
> 
> Dear Prafulla Wadaskar,
> 
> In message 
> <1238759359-6544-1-git-send-email-prafulla at marvell.com> you wrote:
> > From: prafulla_wadaskar <prafulla at marvell.com>
> >
> > This debug_prints strategy provides-
> > A. pre-formatted debug and print macros to be used in a code B. 
> > flexiblility to enable selective debug prints without
> >    modifying a source code
> > For more details refer doc/README.debug_prints
> >
> > Signed-off-by: prafulla_wadaskar <prafulla at marvell.com>
> 
> This seems to be a lot of effort, from code to command line pollution
> - for what exactly?
> 
> Which is the problem you are trying to solve?
If I understood current u-boot debugging properly, the debug statements are enabled by editing src file by adding "#define DEBUG"
Doing this the release contents will be tampered,
this may not be relevant from development point of view.
But the same release will be used by validation/testing/QA guys and to debug anything out of released contents, no one would like to tamper the source code subject to condition proper debugging strategy is in place.

Secondly, even during development it is a pain to enable/disable debug statements for their needs and finally remove them before release. I suffered this pain that's why discovered this strategy.

The suggested patch provides totally optional strategy that offers-
A) enabling selective debug statements without modifying source code
B) enabling selective debug statements only from specific source file/s
C) Last but not least- simple, small, easy to understand code.

Again.. it is an optional value added tool for u-boot developers :-)

Regards..
Prafulla . .

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: 
> wd at denx.de Wisdom is one of the few things that looks bigger 
> the further away it
> is.                               - Terry Pratchett, _Witches Abroad_
>