[U-Boot] [PATCH 2/8] Blackfin: nand: flush peripheral before polling it

[Wolfgang Denk]

Dear Mike Frysinger,

In message <1239004434-13962-3-git-send-email-vapier at gentoo.org> you wrote:
> From: Graf Yang <graf.yang at analog.com>
> 
> We need to make sure the data written to the nand flash controller makes
> it there before we start polling its status register.  Otherwise, we may
> get stale data and return before the controller is actually ready.
> 
> Signed-off-by: Graf Yang <graf.yang at analog.com>
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  drivers/mtd/nand/bfin_nand.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/nand/bfin_nand.c b/drivers/mtd/nand/bfin_nand.c
> index f6a0835..f134ef1 100644
> --- a/drivers/mtd/nand/bfin_nand.c
> +++ b/drivers/mtd/nand/bfin_nand.c
> @@ -98,6 +98,7 @@ static void bfin_nfc_read_buf(struct mtd_info *mtd, uint8_t *buf, int len)
>  
>  		/* Contents do not matter */
>  		bfin_write_NFC_DATA_RD(0x0000);
> +		SSYNC();

Should such syncing not be integral part of the
bfin_write_NFC_DATA_RD() aceessor?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God is real, unless declared integer.