[U-Boot] [PATCH] Add support to Colibri PXA-270 board

Detlev Zundel dzu at denx.de
Tue Apr 7 13:55:37 CEST 2009


Hi Alon,

a new board port without a single (C)opyright by your name - must have
been a hard day copying ;)

> This configuration is based on the trizepsiv board, and the
> work Daniel Mack did in the past [1].
>
> The following files were taken as-is from trizepsiv board:
>  - lowlevel_init.S
>  - pxavoltage.S
>  - u-boot.lds

Isn't this a clear sign to try and find a way to reuse the code for both
boards?  Simply copying a file verbatim is always a mistake.  Who will
copy the bugfixes in the future?

I added Stefano on CC, maybe he has some good input on how to share code
here.

Cheers
  Detlev

-- 
Today people don't go to rock concerts to listen to the music, because
you can't. They go there to be part of the environment.
                                       -- Peter Eisenman
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list