[U-Boot] [PATCH] Add support to Colibri PXA-270 board

[Detlev Zundel]

Hi Alon,

> It was not my intention to add publicity my name, but provide
> a solution for users, as it took a lot of work to make it
> work without many changes from other implementation.

Adding someones name to code that one has written is primarily not for
publicity reasons but for somple tracking reasons.  Who do you think
people will turn to if they see problems in the code?  What would you
say if someone mailed you about a problem in "your" code which you have
never seen before?

> Any way to do it using a reuse would be super, although
> this is not the only duplication in u-boot board tree...

Yes, and maybe you realize how *damn* (sorry) some of us work to
eliminate this.  I never tire of stating that the cost of fixing a
problem in software is exponential to the time of its discovery.

Translated into U-Boot context this means, that we do *not* allow simple
code duplication.  If such a case slips through the review process, this
is nowhere near a reason to allow it the next time.

So please, reconsider adding to the mess instead of decreasing it or
even keeping the mess-level constant ;)

Cheers
  Detlev

-- 
The 82558 B-step and later generation devices do not maintain a link
in D3 if PME is disabled or if the device does not have power.
                                        -- Intel documentation
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de