[U-Boot] [PATCH u-boot git] DaVinci now respects SKIP_LOWLEVEL_INIT

Magnus Lilja lilja.magnus at gmail.com
Tue Apr 14 18:45:14 CEST 2009


Hi

2009/4/14 David Brownell <david-b at pacbell.net>:
> On Tuesday 14 April 2009, Wolfgang Denk wrote:
>> Please don't do it like this. Please use the same style like
>> everybody else.
>
> Having to guess .. you mean don't indent?
>
> ========== CUT HERE
> From: David Brownell <dbrownell at users.sourceforge.net>
>
> Don't needlessly include lowlevel init code; that's only really
> needed with boot-from NOR (not boot-from-NAND).  The 2nd stage
> loader (UBL) handles that before it loads U-Boot.
>
> Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
> ---
>  cpu/arm926ejs/davinci/Makefile |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> --- a/cpu/arm926ejs/davinci/Makefile
> +++ b/cpu/arm926ejs/davinci/Makefile
> @@ -28,7 +28,11 @@ include $(TOPDIR)/config.mk
>  LIB    = $(obj)lib$(SOC).a
>
>  COBJS  = timer.o ether.o lxt972.o dp83848.o
> -SOBJS  = lowlevel_init.o reset.o
> +SOBJS  = reset.o
> +
> +ifndef CONFIG_SKIP_LOWLEVEL_INIT
> +SOBJS  += lowlevel_init.o
> +endif

I was about to suggest that they were hinting at something like:
SOBJS-$(CONFIG_SKIP_LOWLEVEL_INIT) += lowlevel_init.o

But then I realized that lowlevel_init.o should be omitted if
SKIP_LOWLEVEL.. is defined, and I don't know how to do that.

Regards, Magnus


More information about the U-Boot mailing list