[U-Boot] [PATCH u-boot git] fix DaVinci NS16550_REG_SIZE regression

Detlev Zundel dzu at denx.de
Wed Apr 15 10:53:57 CEST 2009


Hi David,

> From: David Brownell <dbrownell at users.sourceforge.net>
>
> Update the DaVinci DM6446 boards to use the new convention
> for CONFIG_SYS_NS16550_REG_SIZE ... the size hasn't changed
> from the original 4 bytes, but these chips are little-endian.
>
> (Resolves a regression added recently by the include/ns16550.h
> patch to "Unify structure declaration for registers".  The code
> previously worked just fine because the registers were accessed
> as host-endian words, not as bytes.)
>
> Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>

Excellent, thanks.  As noted, I was aware that such problems may pop up,
but I think it is nice now to be on the safe side of explicitely
expressing what we do and not obfuscate that with different c types.

Cheers
  Detlev

-- 
Summary [of object-oriented programming in Perl 5]
That's all about there is to it. Now you just need to go off and buy a
book about object-oriented design methodology, and bang  your forehead
with it for the next six months or so.    Larry Wall [Creator of Perl]
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list