[U-Boot] [PATCH] ppc4xx: Remove duplicated code for Sequoia NAND booting version

[Wolfgang Denk]

Dear Stefan Roese,

In message <200904160651.28962.sr at denx.de> you wrote:
>
> > > -#define get_bus_freq(val)	133000000
> > > +#define get_bus_freq(val)	133333333
> > >  #endif
> >
> > To me that does not look exactly like duplicated code removal...
...
> So what the patch does is to remove an unused code part. Is this what you are 
> complaining about? If really needed I could resend this patch with a modified 
> patch subject.

No, I complain that you also change a vital costant without even
mentioning.

Normally, this should be split into two separate patches., but at
least it should be stated in the commit message.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What can it profit a man to gain the whole world and to come  to  his
property with a gastric ulcer, a blown prostate, and bifocals?
                                     -- John Steinbeck, _Cannery Row_