[U-Boot] [PATCH v2] ppc4xx: Remove unused code for Sequoia NAND booting version

[Wolfgang Denk]

Dear Stefan Roese,

In message <1239866038-32703-1-git-send-email-sr at denx.de> you wrote:
> The current define of get_bus_freq() in the CONFIG_NAND_SPL #ifdef is not
> used at all. This patch changes it's define to the currently used value of
> 133333333 and removes the unnecessary code.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  board/amcc/sequoia/sdram.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/board/amcc/sequoia/sdram.c b/board/amcc/sequoia/sdram.c
> index c26e6ee..6df4c6d 100644
> --- a/board/amcc/sequoia/sdram.c
> +++ b/board/amcc/sequoia/sdram.c
> @@ -44,7 +44,7 @@ extern void denali_core_search_data_eye(void);
>   * for the 4k NAND boot image so define bus_frequency to 133MHz here
>   * which is save for the refresh counter setup.
>   */
> -#define get_bus_freq(val)	133000000
> +#define get_bus_freq(val)	133333333
>  #endif
>  
>  /*************************************************************************
> @@ -55,11 +55,7 @@ extern void denali_core_search_data_eye(void);
>  phys_size_t initdram (int board_type)
>  {
>  #if !defined(CONFIG_NAND_U_BOOT) || defined(CONFIG_NAND_SPL)
> -#if !defined(CONFIG_NAND_SPL)
>  	ulong speed = get_bus_freq(0);
> -#else
> -	ulong speed = 133333333;	/* 133MHz is on the safe side	*/
> -#endif
>  
>  	mtsdram(DDR0_02, 0x00000000);

Overwriting the function definition in "cpu/ppc4xx/speed.c" with a
#define like here is pretty ugly. 

Looking closer at this, I think the whole implementation of
get_bus_freq() needs to be cleaned up. Why does get_bus_freq() need
an agument? I don't see it used anywhere - not on 4xx nor on any
other architecture.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I knew then (in 1970) that a 4-kbyte minicomputer would cost as much
as a house. So I reasoned  that  after  college,  I'd  have  to  live
cheaply in an apartment and put all my money into owning a computer."
      - Apple co-founder Steve Wozniak, EE Times, June 6, 1988, pg 45