[U-Boot] [PATCH u-boot git] DaVinci Ethernet cleanup
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Fri Apr 17 07:41:19 CEST 2009
On 15:49 Sun 12 Apr , David Brownell wrote:
> From: David Brownell <dbrownell at users.sourceforge.net>
>
> Chips without the EMAC controller won't need the utilities
> it uses to read an Ethernet address from EEPROM; so don't
> include them needlessly.
>
> Use is_valid_ether() to validate the address from EEPROM.
> All-zero addresses aren't the only invalid addresses.
> A fully erased EEPROM returns all-ones, also invalid...
>
> Switch those Ethernet utilities to use "%pM" for printing
> MAC addresses; and not say ROM when they mean EEPROM.
>
> Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
Looks fine
Ben any comments?
Best Regards,
J.
More information about the U-Boot
mailing list