[U-Boot] [PATCH 2/7] i2c: Create common default i2c_[set|get]_bus_speed() functions

Peter Tyser ptyser at xes-inc.com
Sun Apr 19 05:13:58 CEST 2009


On Sat, 2009-04-18 at 14:23 -0400, Mike Frysinger wrote:
> On Thursday 16 April 2009 15:41:22 Peter Tyser wrote:
> > +unsigned int i2c_get_bus_speed(void)
> > +	__attribute((weak, alias("__def_i2c_get_bus_speed")));
> 
> __attribute__ ?

Interesting, thanks for catching that.  I blindly copied the weak
functions in net/eth.c which also use the __attribute declaration.  It
looks like gcc treats __attribute and __attribute__ the same, but I
couldn't find any definitive info on __attribute.  I'll resubmit using
__attribute__.

Anyone have a reason that we shouldn't replace all u-boot references to
__attribute with __attribute__?

Thanks,
Peter



More information about the U-Boot mailing list