[U-Boot] [PATCH v2] Marvell MV88F6281GTW_GE Board support

[Prafulla Wadaskar]

> > > > +
> > > > +#endif /* CONFIG_MISC_INIT_R */
> > > > diff --git a/board/Marvell/mv88f6281gtw_ge/u-boot.lds
> > > > b/board/Marvell/mv88f6281gtw_ge/u-boot.lds
> > > is it possible to have a shorter name for the board?
> > No Jean, not possible, kernel patches also represents the 
> same name and machine is also register with the same name, 
> pleas bear with this, thanks..
> ok if possible next time try a shorter name
Sure... Except one more exception please "mv88f6192gtw_fe"
This is next board whose kernel support and board name registry is already done in linux,
this will be the next board support patch from me after getting this stuff in.
For next upcomming boards I will keep in mind

> > > > +#define LE			1	/* Specify 
> LE/BE operation */
> > > why?
> > Because SOC can be initialized to work in both the modes.
> so the binary will be compile as LE or BE so __ARMEL__ or 
> __ARMEB__ will be defined 
Okay I will change accordingly

> > > > +#define CONFIG_SYS_MALLOC_LEN	0x00400000	/* 4M */
> > > 4M?
> > What it should be?
> just ask why do you need 4M of malloc?
In future to support all SOC drivers, I will keep it 4M if you agree
 

> > > default load adr- 8M */
> > > > +#define CONFIG_SYS_MEMTEST_START 0x00400000	/* 4M */
> > > > +#define CONFIG_SYS_MEMTEST_END	0x007fffff	/*(_8M -1) */
> > > _8M?
> > What it should be ?
> 8M maybe
:-) I will keep it 8M at this moment

> > > > +#define CONFIG_IPADDR		192.168.5.44
> > > > +#define CONFIG_SERVERIP		192.168.5.30
> > > > +#define CONFIG_NETMASK		255.255.255.0
> > > please remove the IP params
> > Why ?
> it's board instance specific
Okay I will remove them

Regards..
Prafulla . .