[U-Boot] [PATCH v2] Marvell Kirkwood family SOC support

[Prafulla Wadaskar]

> > > > +	u32 enable = (0x01 & KW_REG_READ((0x1504 + bank * 8)));
> > > please create macro for these registers
> > This will be taken care....
> > > please use readx/writex (madatory)
> > You mean instead of KW_REG_READ to be used readx() ?
> readl I guess
> 
> take a look in include/arm-asm/io.h
I understood... Thanks

> > > > +
> > > > +	.globl kw_cpu_if_pre_init
> > > > +kw_cpu_if_pre_init:
> > > do you really need to do this before relocation
> > Yes..
> could add comment to explain why
Okay I will add..

> > > please remove thhis KW_RED_READ_ASM
> > > or do it via asm macro as we have done for sh2/3/4
> > I will check this...
> attached a first version of macro.h file for arm
Thanks ....


> > > and update start.S to call it just be the lowlevel_init
> > You mean to add support for arch_lowlevel_init, using some 
> CONFIG_ option ?
> yes
> CONFIG_ARCH_LOWLEVEL_INIT
Okay, I will release a small separate patch for this because this will be generic to arm other SOCs too

Regards..
Prafulla . .

> 
> Best Regards,
> J.
>