[U-Boot] [PATCH v2] netloop: updates for NetLoop

Wolfgang Denk wd at denx.de
Fri Apr 24 21:45:24 CEST 2009


Dear Ben,

In message <20090403215728.930BE83797DC at gemini.denx.de> I wrote:
> Dear Ben,
> 
> In message <49A641E4.8000001 at denx.de> you wrote:
> > [PATCH v2] netloop: updates for NetLoop
> > 
> > Fix some issues introduced from commit:
> > 2f70c49e5b9813635ad73666aa30f304c7fdeda9
> > suggested by Mike Frysinger.
> > 
> > - added some comment for the env_id variable in common_cmd_nvedit.c
> > - moved some variables in fn scope instead of file scope
> > - NetInitLoop now static void
> > 
> > Signed-off-by: Heiko Schocher <hs at denx.de>
> > ---
> > changes since v1:
> > - added comments from Mike Frysinger
> > 
> >  common/cmd_nvedit.c |    7 +++++++
> >  net/eth.c           |    5 ++---
> >  net/net.c           |    8 +++-----
> >  3 files changed, 12 insertions(+), 8 deletions(-)
> 
> Except for an Ack from Mike I did not see any comments?
> 
> Ditto for this one:
> 
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/55341

Please comment -- if you want, I can apply directly.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I mean, I . . . think to understand you, I just don't know  what  you
are saying ...                        - Terry Pratchett, _Soul Music_


More information about the U-Boot mailing list