[U-Boot] [PATCH 1/2] OMAP3: Remove unused board-types

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Fri Apr 24 22:03:23 CEST 2009


On 21:34 Fri 24 Apr     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090424164422.GB2953 at game.jcrosoft.org> you wrote:
> > On 20:21 Fri 24 Apr     , Sanjeev Premi wrote:
> > > The board-types defined in struct omap3_sysinfo seem to be
> > > unused. The function display_board_info() is passed
> > > board type as an argument; which is ignored.
> > > 
> > > This patch removes all uses of board-type, related definitions
> > > and functions.
> > I've forget to tell you this on the precedent patch but we have
> >  print_cpuinfo for printing cpu/soc info and checkboard for board info
> > 
> > could you move the STD API 
> 
> What exactly do you mean by "move the STD API"? 
> 
> In which way should the "STD API" be moved, and what exactly is the
> "STD API" you are referring to?

extract of arm init function

#if defined(CONFIG_DISPLAY_CPUINFO)
	print_cpuinfo,		/* display cpu info (and speed) */
#endif
#if defined(CONFIG_DISPLAY_BOARDINFO)
	checkboard,		/* display board info */
#endif

I want we use the current API and not re-invent a new API for an arch only

so Sanjeev please use it

> 
> 
> And please, could you *please* be clear about what your comments mean
> - I have no idea if your comment above  means  that  you  reject  the
> patch,  or  if  you  request  it to be changed (in which case I don;t
> understand how it should be changed, or why), or if you are going  to
> apply it.
Change requested

Best Regards,
J.


More information about the U-Boot mailing list